Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-networked component to despawned predicted entity test #813

Merged
merged 3 commits into from
Jan 13, 2025
Merged

Add non-networked component to despawned predicted entity test #813

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
edbfad5
add unit tests for predicted despawn
cBournhonesque Jan 13, 2025
2d09ad4
add non-protocol component
cBournhonesque Jan 13, 2025
88e5625
Merge branch 'main' into cb/pred-test-despawn
cBournhonesque Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion lightyear/src/client/prediction/despawn.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,10 @@ mod tests {
use crate::prelude::{client, server, NetworkTarget};
use crate::tests::protocol::{ComponentSyncModeFull, ComponentSyncModeSimple};
use crate::tests::stepper::BevyStepper;
use bevy::prelude::default;
use bevy::prelude::{default, Component};

#[derive(Component, Debug, PartialEq)]
struct TestComponent(usize);

/// Test that if a predicted entity gets despawned erroneously
/// The rollback re-adds the predicted entity.
Expand Down Expand Up @@ -217,6 +220,12 @@ mod tests {
.get::<Confirmed>()
.expect("Confirmed component missing");
let predicted_entity = confirmed.predicted.unwrap();
// try adding a non-protocol component (which could be some rendering component)
stepper
.client_app
.world_mut()
.entity_mut(predicted_entity)
.insert(TestComponent(1));

// despawn the predicted entity locally
stepper
Expand All @@ -226,7 +235,13 @@ mod tests {
.entity(predicted_entity)
.prediction_despawn();
stepper.frame_step();
// TODO: this does not work!
// make sure that all components have been removed
// assert!(stepper
// .client_app
// .world()
// .get::<TestComponent>(predicted_entity)
// .is_none());
assert!(stepper
.client_app
.world()
Expand Down Expand Up @@ -262,7 +277,16 @@ mod tests {
.unwrap(),
&ComponentSyncModeFull(2.0)
);
// TODO: NON-REGISTERED COMPONENTS DO NOT WORK!
// the non-Full components should also get restored
// assert_eq!(
// stepper
// .client_app
// .world()
// .get::<TestComponent>(predicted_entity)
// .unwrap(),
// &TestComponent(1)
// );
assert_eq!(
stepper
.client_app
Expand Down
Loading