Separate new() and new_with_app_id() #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -31,6 +31,18 @@ impl SteamworksClient { | |||
| } | |||
| } | |||
|
|
|||
| /// Creates and initializes the Steamworks client. This must only be called | |||
| /// once per application run. | |||
There was a problem hiding this comment.
Can you add a comment that the app_id will usually be read from a steam_appid.txt file?
There was a problem hiding this comment.
Sure, I copied the comment from the steamworks rs docs:
https://docs.rs/steamworks/latest/steamworks/struct.Client.html#method.init
Copied from the steamworks rs docs.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you call init() on the SteamAPI, it will automatically determine the AppId, otherwise you can call init_app() and provide an explicit AppId.
https://docs.rs/steamworks/latest/steamworks/struct.Client.html#method.init