Move protocol module to separate crate in workspace #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctrlaltf24
approved these changes
Jul 25, 2024
| @@ -26,7 +26,7 @@ pub struct HeaderInfo { | |||
|
|
|||
| impl HeaderInfo { | |||
| /// Size of a full TACACS+ packet header. | |||
| pub(in crate::protocol) const HEADER_SIZE_BYTES: usize = 12; | |||
| pub const HEADER_SIZE_BYTES: usize = 12; | |||
There was a problem hiding this comment.
This used to be pub(in crate::protocol)
Suggested change
| pub const HEADER_SIZE_BYTES: usize = 12; | |
| pub(crate) const HEADER_SIZE_BYTES: usize = 12; |
There was a problem hiding this comment.
When working on the actual client, I ended up changing it to pub(crate) since I used it when reading a packet from a connection, which is why I made it fully pub here (since they will technically be different crates now). I'm fine leaving it as pub(crate) here but I'll likely change anyways once the initial client stuff is merged.
There was a problem hiding this comment.
you can keep it as pub if you want, interested to see where this was needed in the client, seems more like a protocol matter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly due to Cargo not supporting optional dev-dependencies, which is inconvenient if we want to have client-specific (std-only) dev dependencies while having it in the same crate. It does make sense to break it out regardless though since I imagine packet (de)serialization can be useful even without a client.
Everything was basically directly moved over, with some imports changed here and there for correctness.