-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge 1.19.4 into 1.20.2 #4172
Merge 1.19.4 into 1.20.2 #4172
Conversation
Not a problem. Codacy being happy is nice but not required. |
@ZacSharp Not sure if it's related to this, but i'm using the build from the CI and i'm getting crash reports from FasterWorldScanner but it appears to be a different location than the original bug. Happens when mining below y = 0, but only on a vanilla server with some datapacks. Tested on singleplayer and issue doesn't occur. I'll attach the relevant log section (no other mods): Not sure if I should submit a bug report since I'm using this build, and it hasn't been merged yet. |
Hmmm, I'm not sure, maybe we want to merge into 1.20.1 then 1.20.2? But I guess this is okay. |
I can still make a merge into 1.20.1 if you want to provide more updates for it. Just let me know. |
I personally don't want to deal with 1.12.2 anymore but I'm willing to merge stuff. Make PRs to master, cherry-pick would be good. 👍 |
#4112 is the sole reason for this pr. Otherwise I'd wait until there's more things to merge.
EDIT: totally forgot about 91588ca even though I looked at it's diff 30 seconds ago...