Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.21 #4394

Merged
merged 2 commits into from
Jul 20, 2024
Merged

1.21 #4394

merged 2 commits into from
Jul 20, 2024

Conversation

rfresh2
Copy link
Contributor

@rfresh2 rfresh2 commented Jun 16, 2024

Fabric working but Forge/NeoForge still busted like on 1.20.5/6

Tested Fabric + Forge + NeoForge working

@StupidRepo
Copy link

Hiya, I tried building for fabric and it froze upon executing #mine iron_ore. Just thought I'd let you know 👍

@rfresh2
Copy link
Contributor Author

rfresh2 commented Jun 19, 2024

@StupidRepo working fine for me

Base.Profile.2024.06.19.-.14.07.57.03.mp4

@StupidRepo
Copy link

StupidRepo commented Jun 20, 2024

Hm, strange... I'll try again later today. There could be mods conflicting. Some possible ones could be Iris Shaders or Sodium maybe.

@rfresh2
Copy link
Contributor Author

rfresh2 commented Jun 20, 2024

forge + neoforge now working after rebasing on latest 1.20.5 branch

@gabb1233333333
Copy link

forge + neoforge now working after rebasing on latest 1.20.5 branch

@rfresh2
How can i use your version (1,21)?

@rfresh2
Copy link
Contributor Author

rfresh2 commented Jun 21, 2024

forge + neoforge now working after rebasing on latest 1.20.5 branch

@rfresh2 How can i use your version (1,21)?

Download the "Artifacts" from the CI: https://github.com/cabaletta/baritone/actions/runs/9593797633

@StupidRepo
Copy link

StupidRepo commented Jun 22, 2024

forge + neoforge now working after rebasing on latest 1.20.5 branch

@rfresh2 How can i use your version (1,21)?

Download the "Artifacts" from the CI: https://github.com/cabaletta/baritone/actions/runs/9593797633

BTW, this is what I did when I said it crashed.

@dave9123
Copy link

dave9123 commented Jul 3, 2024

Screenshot_2024-07-03-20-49-57-76_320a9a695de7cdce83ed5281148d6f19.jpg

Is that supposed to be baritoe?

@pastadudes
Copy link

i sometimes have weird glitching visual artifacts when using 1.21 version tho

@StupidRepo
Copy link

StupidRepo commented Jul 4, 2024

[image hidden because it's so f*cking big]
Is that supposed to be baritoe?

😬 Please keep in mind that you can make a comment on PR commits...

Screenshot 2024-07-04 at 15 12 11

@dave9123

@ZacSharp
Copy link
Collaborator

ZacSharp commented Jul 7, 2024

Baritoe is indeed the correct mod id.

@gvf66
Copy link

gvf66 commented Jul 8, 2024

hello im new how do i download this mod

@dave9123
Copy link

dave9123 commented Jul 8, 2024 via email

@gvf66
Copy link

gvf66 commented Jul 8, 2024

sorry what does that mean

@rycbar0
Copy link
Contributor

rycbar0 commented Jul 8, 2024

as you can write here i assume you already have a github account and are logged in to it.
go to https://github.com/cabaletta/baritone/actions/runs/9593797633 and download the artifacts. unzip the file and copy the baritone jar of your choice to your mods folder

@dave9123
Copy link

dave9123 commented Jul 9, 2024

Forgot that exists

1 similar comment
@dave9123
Copy link

dave9123 commented Jul 9, 2024

Forgot that exists

@gvf66
Copy link

gvf66 commented Jul 9, 2024

Screenshot 2024-07-09 090736
did i do this right

@rycbar0
Copy link
Contributor

rycbar0 commented Jul 9, 2024

if it works yes else try the one with fabric in the name

@gvf66
Copy link

gvf66 commented Jul 10, 2024

will i still need api for that one

@gvf66
Copy link

gvf66 commented Jul 10, 2024

sorry that was a dumb question nvm

@Karol532
Copy link

@StupidRepo working fine for me
Base.Profile.2024.06.19.-.14.07.57.03.mp4

how to install baritone for 1.21 minecraft java? Yes i am new and i have accidently used 9minecraft page so i need help

@Karol532
Copy link

i sometimes have weird glitching visual artifacts when using 1.21 version tho

how to install 1.21 version pls help i am newbie i beg you

@guuuuuug
Copy link

i sometimes have weird glitching visual artifacts when using 1.21 version tho

how to install 1.21 version pls help i am newbie i beg

Everything is mentioned above, but don’t forget to take out the .jar file from Artifacts folder

@Karol532
Copy link

i sometimes have weird glitching visual artifacts when using 1.21 version tho

how to install 1.21 version pls help i am newbie i beg

Everything is mentioned above, but don’t forget to take out the .jar file from Artifacts folder

YES IT WORKS, THANK YOU. and i have question. Is this a good page for fabric? ->https://fabricmc.net/use/installer/<- What should I do if I thoughtlessly downloaded baritone from the 9minecraft website and now I am afraid that I have downloaded some viruses? what is the procedure to protect yourself?

@65-7a
Copy link

65-7a commented Jul 13, 2024

What should I do if I thoughtlessly downloaded baritone from the 9minecraft website and now I am afraid that I have downloaded some viruses? what is the procedure to protect yourself?

reinstall windoze

@dave9123
Copy link

dave9123 commented Jul 13, 2024 via email

@ZacSharp
Copy link
Collaborator

@rfresh2 is anything missing to get this merged?

@rfresh2
Copy link
Contributor Author

rfresh2 commented Jul 19, 2024

@rfresh2 is anything missing to get this merged?

its complete

@rycbar0
Copy link
Contributor

rycbar0 commented Jul 19, 2024

can i request a last minute change to baritone.utils.schematic.format.DefaultFormats

  LITEMATICA("litematic") {
        @Override
        public IStaticSchematic parse(InputStream input) throws IOException {
            CompoundTag nbt = NbtIo.readCompressed(input, NbtAccounter.unlimitedHeap());
            int version = nbt.getInt("Version");
            switch (version) {
                case 4: //1.12
                case 5: //1.13-1.17
                case 6: //1.18-1.20
                    throw new UnsupportedOperationException("This litematic Version is too old.");
                case 7: //1.21+
                    return new LitematicaSchematic(nbt, false);
                default:
                    throw new UnsupportedOperationException("Unsuported Version of a Litematica Schematic");
            }
        }
    };

@rfresh2
Copy link
Contributor Author

rfresh2 commented Jul 19, 2024

can i request a last minute change to baritone.utils.schematic.format.DefaultFormats

done

Copy link
Collaborator

@ZacSharp ZacSharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a generic RuntimeException which could be IllegalArgumentException and the inline enchantment loops could be factored out, but generally looks fine.

@ZacSharp ZacSharp requested a review from leijurv July 20, 2024 12:25
@leijurv leijurv changed the base branch from 1.20.5 to 1.21 July 20, 2024 18:52
@leijurv leijurv merged commit 8786148 into cabaletta:1.21 Jul 20, 2024
3 of 4 checks passed
@Zocyet
Copy link

Zocyet commented Aug 17, 2024

啊啊啊看不懂英文怎么办?

@dave9123
Copy link

dave9123 commented Aug 17, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.