Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DP-627 - Migration - Add scopes to persons entity. #655

Merged

Conversation

rmohammed-goaco
Copy link
Collaborator

No description provided.

@jakzal
Copy link
Member

jakzal commented Sep 25, 2024

Automapper definitions need an update: https://github.com/cabinetoffice/GCGS-Central-Digital-Platform/actions/runs/11030709432/job/30635875026?pr=655#step:6:219

[xUnit.net 00:00:00.29]     CO.CDP.Person.WebApi.Tests.AutoMapper.WebApiToPersistenceProfileTest.ConfigurationIsValid [FAIL]
  Failed CO.CDP.Person.WebApi.Tests.AutoMapper.WebApiToPersistenceProfileTest.ConfigurationIsValid [16 ms]
  Error Message:
   AutoMapper.AutoMapperConfigurationException : 
Unmapped members were found. Review the types and members below.
Add a custom mapping expression, ignore, add a custom resolver, or modify the source/destination type
For no matching constructor, add a no-arg ctor, add optional arguments, or map all of the constructor parameters
===============================================================================================
RegisterPerson -> Person (Destination member list)
CO.CDP.Person.WebApi.Model.RegisterPerson -> CO.CDP.OrganisationInformation.Persistence.Person (Destination member list)

Unmapped properties:
Scopes

jakzal and others added 7 commits September 25, 2024 11:32
…of github.com:cabinetoffice/GCGS-Central-Digital-Platform into DP-627-migration-create-supportadmin-scope-on-persons
…of github.com:cabinetoffice/GCGS-Central-Digital-Platform into DP-627-migration-create-supportadmin-scope-on-persons
@rmohammed-goaco rmohammed-goaco merged commit 83f9ef8 into main Sep 27, 2024
8 checks passed
@dharmverma dharmverma deleted the DP-627-migration-create-supportadmin-scope-on-persons branch October 2, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants