DP-614: Added notification message if CH not found or if company already registered #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andymantell
requested changes
Sep 26, 2024
Frontend/CO.CDP.OrganisationApp/Pages/Shared/_FlashMessage.cshtml
Outdated
Show resolved
Hide resolved
Frontend/CO.CDP.OrganisationApp/ThirdPartyApiClients/CompaniesHouse/CompaniesHouseApi.cs
Show resolved
Hide resolved
andymantell
approved these changes
Sep 26, 2024
dharmverma
reviewed
Sep 26, 2024
| var result = await _companiesHouseApi.GetProfile(companyNumber); | ||
|
|
||
| // Assert | ||
| Assert.NotNull(result); |
There was a problem hiding this comment.
As discussed earlier in dev meetings, please use FluentAssertion
There was a problem hiding this comment.
Thanks for the review, updated.
dharmverma
reviewed
Sep 26, 2024
| [Fact] | ||
| public async Task GetProfile_ShouldReturnCompanyProfile() | ||
| { | ||
| // Arrange |
There was a problem hiding this comment.
Remove these comments
dharmverma
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DP-614