Feature/dp 670 manipulating urls records creating bug #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andymantell
approved these changes
Oct 16, 2024
jakzal
reviewed
Oct 16, 2024
dpatel017
approved these changes
Oct 16, 2024
shilpigoel-goaco
approved these changes
Oct 16, 2024
JBaigGoaco
deleted the
feature/DP-670-manipulating-urls-records-creating-bug
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issued in forms where manipulating the URLs records can create new database entries and jumping onto wrong pages in the journey.
Details:
manipulating the URLs records and passing question IDs manually can create new data in the DB and navigates to different pages which is fixed in this PR. when someone will hack the URLs we will bring them back to the valid question type based on the locally stored answersSet and determining the order of the questions based on SortOrder number to go to the valid screen in the Journey.