Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default export #14

Merged
merged 1 commit into from
Oct 17, 2017
Merged

default export #14

merged 1 commit into from
Oct 17, 2017

Conversation

shepherdwind
Copy link
Contributor

@shepherdwind shepherdwind commented Oct 9, 2017

Since 1.2.0 ,there is some problem type error. such as #13

In most cases , TypeScript use es6 syntax import , for example import xx from 'oo' , which will more common to use.

@williamkapke williamkapke merged commit 8676ec1 into cabinjs:master Oct 17, 2017
@williamkapke
Copy link
Collaborator

Ok. Sorry about that. I'm not a TS person- so, unfortunately I can only eyeball the TS contributions 😟

I'd love to have more eyes on this module! (it doesn't really change much) Please hit "watch" and drop in to review proposed PRs.

Thanks!

@williamkapke williamkapke mentioned this pull request Oct 17, 2017
@shepherdwind shepherdwind deleted the export-default branch October 17, 2017 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants