Add missed TS definitions for setMachineID and getMachineID #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I do not support TypeScript and will not accept this. It is up to William on this one. TypeScript is bad for the JavaScript community, and even authors like Ryan Dahl (original creator of Node.js and creator of Deno) has abandoned it on Deno. |
|
I'm not a fan of TS either-- but I've been allowing this TS file to be PRd with the note that it's not supported and I only glance at the change (no effort put in to ensure it's a valid change). This change seems harmless. I'll merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
Working on project with Typescript I found that definitions for
setMachineIDandgetMachineIDis missedThank you