Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pid set to NaN in browserify #5

Merged
merged 2 commits into from
Nov 30, 2015
Merged

Fix pid set to NaN in browserify #5

merged 2 commits into from
Nov 30, 2015

Conversation

rahatarmanahmed
Copy link
Contributor

  • Added a check to see if the process.pid exists, as browserify provides a process global but it does not have a pid property.
  • Also added node_modules/ to .gitignore

That conditional statement is a bit long now, so let me know if you want me to break it up or something.

Fixes #4

williamkapke added a commit that referenced this pull request Nov 30, 2015
Fix pid set to NaN in browserify
@williamkapke williamkapke merged commit 45a9d85 into cabinjs:master Nov 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants