Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix to undefined process returning true in objectID string #9

Merged
merged 1 commit into from
Jan 18, 2017

Conversation

karn09
Copy link
Contributor

@karn09 karn09 commented Jan 18, 2017

When process is undefined, pid returns true. This causes the generate function to return an ObjectID string containing 'true'.

@williamkapke williamkapke merged commit 56d5626 into cabinjs:master Jan 18, 2017
@williamkapke
Copy link
Collaborator

Good catch. Thanks!

@williamkapke
Copy link
Collaborator

published 1.1.5

@karn09
Copy link
Contributor Author

karn09 commented Jan 18, 2017

Awesome, thanks for pulling that in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants