OTP-26 support #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change Erlang configuration fetch calls in the Makefile to eliminate race OTP-26 related conditions
|
@cabol may I ask you to have a look at this PR? |
|
Hey 👋 !! Thanks for the PR, at first glance LGTM, however, may I suggest you add the OTP 26 to the CI (since you're adding the 26, we can take advantage to also add the 25 since it is missing too)? Here: https://github.com/cabol/jchash/blob/master/.github/workflows/ci.yml#L15. THANKS!! |
|
@cabol sure, I've made changes. Thanks! |
|
Sorry, I had to fix the CI because it was broken, and also took advantage to update the Makefile (via |
|
@cabol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Erlang configuration fetch calls in the Makefile to eliminate race OTP-26 related conditions
More details in erlang/otp#6916