Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPUnit Cleanup - Fixes #2053 #2055

Merged
merged 2 commits into from
Aug 13, 2016
Merged

PHPUnit Cleanup - Fixes #2053 #2055

merged 2 commits into from
Aug 13, 2016

Conversation

ConnorVG
Copy link
Contributor

See #2053

@ConnorVG
Copy link
Contributor Author

Sorry, had to make a cup of tea :trollface:

@GrahamCampbell GrahamCampbell added this to the V2.4.0 milestone Aug 13, 2016
@GrahamCampbell
Copy link
Contributor

image

@GrahamCampbell
Copy link
Contributor

Thanks, looks good. Will merge once travis is done with it.

@ConnorVG
Copy link
Contributor Author

Trust me, I tested it locally.

It totally works :trollface:

:trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface: :trollface:

@GrahamCampbell GrahamCampbell merged commit a7a555e into cachethq:2.4 Aug 13, 2016
@GrahamCampbell
Copy link
Contributor

:trollface:

yoyosan
yoyosan reviewed Aug 13, 2016
View reviewed changes
tests/TestListener.php
return;
}

foreach (glob(__DIR__.'/../bootstrap/cache{,t}/*.php', GLOB_BRACE) as $file) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a neat trick. 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😉

Copy link

@yoyosan yoyosan Aug 14, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't calling the artisan config:clear command be easier?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To go through the trouble of booting another instance? We also need to ensure tests don't mutate any other compiled or cached data like services and the configs in cachet/*.

This is all-round quicker to execute and more exhaustive.

@ConnorVG ConnorVG deleted the phpunit-cleanup branch August 14, 2016 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.4
Development

Successfully merging this pull request may close these issues.
3 participants
@ConnorVG @GrahamCampbell @yoyosan