Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated Fixes Generated By StyleCI #80

Closed
wants to merge 1 commit into from
Closed

Automated Fixes Generated By StyleCI #80

wants to merge 1 commit into from

Conversation

GrahamCampbell
Copy link
Contributor

@jbrooksuk
Copy link
Member

I wonder why this can't merge?

@jbrooksuk
Copy link
Member

Ah, it's to do with the changes I made just before you. Could you run again?

@GrahamCampbell
Copy link
Contributor Author

Yeh.

@GrahamCampbell
Copy link
Contributor Author

I don't like the namespace change. Are you not going to rename the folder to correct the case first?

@jbrooksuk
Copy link
Member

Yeah, I'm just trying to get it to work, Git is throwing a paddy at me, even with the -f param.

@GrahamCampbell
Copy link
Contributor Author

Just rename it to something wrong, commit, then change it again. I sometimes do that. :)

@jbrooksuk
Copy link
Member

That'll work - I was trying to be clever :P

@jbrooksuk
Copy link
Member

Done :)

@GrahamCampbell
Copy link
Contributor Author

You know, styleci can be enabled for this repo if you want.

@GrahamCampbell
Copy link
Contributor Author

All you need to do is setup a hook.

@jbrooksuk
Copy link
Member

That'd be good, we don't have anything enforcing the style yet.

@jbrooksuk
Copy link
Member

BTW, just pushed a change for composer.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants