Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complain about unknown arguments #93

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Complain about unknown arguments #93

merged 1 commit into from
Jul 17, 2023

Conversation

yatsukhnenko
Copy link
Contributor

root@localhost:/relay# benchmarks/run --workers 1 --foo bar

 ERROR  Unknown option '--foo'.

@tillkruss
Copy link
Member

Nice, you tested that they all still work?

@yatsukhnenko
Copy link
Contributor Author

@tillkruss Not all combination of args but yeah

root@localhost:/relay# benchmarks/run --workers 1              
Setting up on AMD Ryzen 7 4700U with Radeon Graphics (8 cores/8 threads x86_64)
Using PHP 8.1.21 (OPcache: Off, Xdebug: Off, New Relic: Off)
Connected to Redis (7.0.11) at tcp://127.0.0.1:6379


 GET  Executing 5 iterations (1 warmup) for 1.00s seconds

+--------------+--------+---------+---------+---------+-------------+--------+--------+--------+
| Client       | Memory | Network | Workers | IOPS    | IOPS/Worker | rstdev | Change | Factor |
+--------------+--------+---------+---------+---------+-------------+--------+--------+--------+
| RelayNoCache | 3.72mb | 12.43mb |       1 |  32.42K |      32.42K | ±0.17% |  0.00% |  1.00x |
| Predis       | 3.72mb | 13.19mb |       1 |  34.90K |      34.90K | ±0.15% |  7.67% |  1.08x |
| PhpRedis     | 3.72mb | 13.94mb |       1 |  36.44K |      36.44K | ±0.16% | 12.40% |  1.12x |
| Relay        | 3.72mb |    181b |       1 | 369.89K |     369.89K | ±0.15% | 1,041% |  11.4x |
+--------------+--------+---------+---------+---------+-------------+--------+--------+--------+

@yatsukhnenko
Copy link
Contributor Author

Also run with composer

root@localhost:/relay# php composer.phar run bench -- --worker 1 
> @php benchmarks/run '--worker' '1'

 ERROR  Unknown option '--worker'.
Script @php benchmarks/run handling the bench event returned with error code 1
root@localhost:/relay# php composer.phar run bench -- --workers 1 
> @php benchmarks/run '--workers' '1'
Setting up on AMD Ryzen 7 4700U with Radeon Graphics (8 cores/8 threads x86_64)
Using PHP 8.1.21 (OPcache: Off, Xdebug: Off, New Relic: Off)
Connected to Redis (7.0.11) at tcp://127.0.0.1:6379


 GET  Executing 5 iterations (1 warmup) for 1.00s seconds

+--------------+--------+---------+---------+---------+-------------+--------+--------+--------+
| Client       | Memory | Network | Workers | IOPS    | IOPS/Worker | rstdev | Change | Factor |
+--------------+--------+---------+---------+---------+-------------+--------+--------+--------+
| RelayNoCache | 3.72mb | 10.17mb |       1 |  26.37K |      26.37K | ±0.10% |  0.00% |  1.00x |
| Predis       | 3.72mb | 10.17mb |       1 |  26.91K |      26.91K | ±3.07% |  2.04% |  1.02x |
| PhpRedis     | 3.72mb | 11.30mb |       1 |  29.11K |      29.11K | ±0.31% | 10.39% |  1.10x |
| Relay        | 3.72mb |    181b |       1 | 310.37K |     310.37K | ±5.31% | 1,077% |  11.8x |
+--------------+--------+---------+---------+---------+-------------+--------+--------+--------+

@tillkruss tillkruss merged commit 4525414 into main Jul 17, 2023
@tillkruss tillkruss deleted the benchmarks branch July 17, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants