Include every "length" command + generic way to set typed keys #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Relay caches in-memory the "length" information about keys of any type, so we should include all of these commands in our benchmark suite. * Add a generic helper method that uses our flags to set keys of a given type in a generic way.
michael-grunder
force-pushed
the
include-all-len-commands
branch
from
b184fd0
to
03bf1df
Compare
|
What a nice PR ✔️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relay caches in-memory the "length" information about keys of any type, so we should include all of these commands in our benchmark suite.
Add a generic helper method that uses our flags to set keys of a given type in a generic way.