Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store-scan: improve error handling when listing the store fails #183

Merged
merged 2 commits into from
May 8, 2024

Conversation

sandydoo
Copy link
Member

@sandydoo sandydoo commented May 7, 2024

  • Ensures that we don't upload anything if the either the pre- or post-build store listing fails.
  • Uses $RUNNER_TEMP to store the path listing with os.tmpdir() as fallback.

Fixes #179.

@sandydoo sandydoo marked this pull request as ready for review May 7, 2024 21:05
@sandydoo sandydoo requested a review from domenkozar May 7, 2024 21:06
@domenkozar domenkozar merged commit 132bc97 into master May 8, 2024
15 checks passed
haraldh referenced this pull request in matter-labs/vault-auth-tee May 21, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [cachix/cachix-action](https://togithub.com/cachix/cachix-action) |
action | major | `v14` -> `v15` |

---

### Release Notes

<details>
<summary>cachix/cachix-action (cachix/cachix-action)</summary>

### [`v15`](https://togithub.com/cachix/cachix-action/releases/tag/v15):
cachix-action-v15

[Compare
Source](https://togithub.com/cachix/cachix-action/compare/v14...v15)

#### What's Changed

- Pass `cachixArgs` to the daemon by
[@&#8203;sandydoo](https://togithub.com/sandydoo) in
[https://github.com/cachix/cachix-action/pull/177](https://togithub.com/cachix/cachix-action/pull/177)
- Support path filtering when using the daemon by
[@&#8203;sandydoo](https://togithub.com/sandydoo) in
[https://github.com/cachix/cachix-action/pull/182](https://togithub.com/cachix/cachix-action/pull/182)
- Skip prep steps if using `pathsToPush` by
[@&#8203;sandydoo](https://togithub.com/sandydoo) in
[https://github.com/cachix/cachix-action/pull/180](https://togithub.com/cachix/cachix-action/pull/180)
- store-scan: improve error handling when listing the store fails by
[@&#8203;sandydoo](https://togithub.com/sandydoo) in
[https://github.com/cachix/cachix-action/pull/183](https://togithub.com/cachix/cachix-action/pull/183)

**Full Changelog**:
cachix/cachix-action@v14...v15

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [x] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/matter-labs/vault-auth-tee).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjMuNSIsInVwZGF0ZWRJblZlciI6IjM3LjM2My41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
renovate bot referenced this pull request in bobvanderlinden/nixpkgs-ruby Jun 9, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [cachix/cachix-action](https://togithub.com/cachix/cachix-action) |
action | major | `v14` -> `v15` |

---

### Release Notes

<details>
<summary>cachix/cachix-action (cachix/cachix-action)</summary>

### [`v15`](https://togithub.com/cachix/cachix-action/releases/tag/v15):
cachix-action-v15

[Compare
Source](https://togithub.com/cachix/cachix-action/compare/v14...v15)

#### What's Changed

- Pass `cachixArgs` to the daemon by
[@&#8203;sandydoo](https://togithub.com/sandydoo) in
[https://github.com/cachix/cachix-action/pull/177](https://togithub.com/cachix/cachix-action/pull/177)
- Support path filtering when using the daemon by
[@&#8203;sandydoo](https://togithub.com/sandydoo) in
[https://github.com/cachix/cachix-action/pull/182](https://togithub.com/cachix/cachix-action/pull/182)
- Skip prep steps if using `pathsToPush` by
[@&#8203;sandydoo](https://togithub.com/sandydoo) in
[https://github.com/cachix/cachix-action/pull/180](https://togithub.com/cachix/cachix-action/pull/180)
- store-scan: improve error handling when listing the store fails by
[@&#8203;sandydoo](https://togithub.com/sandydoo) in
[https://github.com/cachix/cachix-action/pull/183](https://togithub.com/cachix/cachix-action/pull/183)

**Full Changelog**:
cachix/cachix-action@v14...v15

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "every weekend" (UTC), Automerge - At
any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/bobvanderlinden/nixpkgs-ruby).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ0YXJnZXRCcmFuY2giOiJtYXN0ZXIiLCJsYWJlbHMiOltdfQ==-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When running on self-hosted runner, tripped and started uploading absolutely everything
2 participants