-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid --impure in flake-parts based projects #1018
Conversation
5efce28
to
c69453e
Compare
We should probably make it a JSON to pass other things like |
I think one value per input approach would be nice, otherwise we will have to deal with JSON escape things in |
@domenkozar Would you like to approve the CI workflows? |
Without these changes I get:
With the changes I get a further, but apparently there is still a problem:
Oddly, the |
@khaled Fixed |
Thanks @Atry! FYI, this probably belongs in a separate bug, but the existence of the
Simply removing the package definition resolves it. |
@domenkozar I don't understand the CI failure message. Could you help me understanding why? |
@domenkozar I rebased this PR. Would you mind approving the CI workflows? |
@domenkozar I think the CI failure is not due to this PR. The |
I am wondering if it would make sense to also update the flake integration wrapper to not use |
@domenkozar could you trigger CI for this PR? |
Let
.envrc
generate thedevenv.root