-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(scripts): allow custom interpreters #1256
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenkozar
reviewed
Jun 8, 2024
binary sounds good!
…On Sat, Jun 8, 2024, 14:15 David Flanagan ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/modules/scripts.nix
<#1256 (comment)>:
> - type = types.str;
- description = "Bash code to execute when the script is run.";
- };
- description = lib.mkOption {
- type = types.str;
- description = "Description of the script.";
- default = "";
+ scriptType = types.submodule (
+ { config, ... }:
+ {
+ options = {
+ exec = lib.mkOption {
+ type = types.str;
+ description = "Shell code to execute when the script is run.";
+ };
+ interpreter = lib.mkOption {
No problem. Are you happy with binary, or is there a convention there too?
Bin?
—
Reply to this email directly, view it on GitHub
<#1256 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA63AZHAW2BKKXWA62EVVTZGLYWPAVCNFSM6AAAAABI735EVKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMBVHAZTSMRYGE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
domenkozar
requested changes
Jun 8, 2024
Co-authored-by: Domen Kožar <domen@enlambda.com>
Oops. I'm using the wrong formatter I think |
@rawkode seems like you need to run |
@domenkozar I'm learning. Should be sorted now. Thanks for the assist. |
No worries, that's why I'm here to help :) |
domenkozar
reviewed
Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #907