-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rust: replace fenix with rust-overlay allow specifying rust version #1500
base: main
Are you sure you want to change the base?
Conversation
2d0eb48
to
b454a69
Compare
I fixed targets not working, but it's not pretty. I copied |
We should error out of channel values in version, to properly instruct how to migrate for users that are still using version for channels. |
FYI, both rust examples fail in CI. |
@eyJhb would be great to get this in! |
I am unsure how this should be done, can you give me any pointers? Tests and docs should be fixed now. The failing test on main should also be working now (it seemed to be failing before). |
Nice! I think it needs |
Should be done now! :) |
It seems like rust-cross-wasm failed with clippy hook:
|
Ah, seems that's an existing bug using git-hooks. I'll test this soon! |
@domenkozar rebased ! :) |
Adds basic support for specifying the version of the rust toolchain you want to use.
This change moves away from using fenix, to instead using rust-overlay.
It seems to work just fine, and is somewhat minimal invasive.
TODO:
Example: