devenv: convert logging to use tracing ecosystem
#1566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandydoo
force-pushed
the
migrate-logging
branch
from
fac3f42
to
1a0148d
Compare
sandydoo
force-pushed
the
migrate-logging
branch
from
1a0148d
to
8b0c37e
Compare
Deploying devenv with
|
| Latest commit: |
d9fff24
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d6da1fc9.devenv.pages.dev |
| Branch Preview URL: | https://migrate-logging.devenv.pages.dev |
sandydoo
force-pushed
the
migrate-logging
branch
from
1344616
to
925cae0
Compare
sandydoo
force-pushed
the
migrate-logging
branch
from
925cae0
to
6f2f04c
Compare
domenkozar
requested changes
Nov 27, 2024
sandydoo
force-pushed
the
migrate-logging
branch
2 times, most recently
from
b659346
to
7341a94
Compare
[skip ci]
[skip ci]
Also make sure to print out non-user messages.
sandydoo
force-pushed
the
migrate-logging
branch
from
e884920
to
d9fff24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts devenv to use the tracing ecosystem for logging.
Usage
You can now use tracing macros to output events:
debug!,info!,error!, etc.Adding a
devenv.is_user_messageboolean field to the event formats it as a step.Steps can also be created with spans:
info_span!,error_span!, etc.Adding a
devenv.user_message = "..."field to the span makes it output events for the start and end of the span.The latter also outputs timings.
RUST_LOGLogging can be additionally configured using the
RUST_LOGenvironment variable.Logging formats
devenv supports two log formats via the
--log-formatoption:cliandtracing-full.--log-format cliThe default. Mimics the existing CLI logging format.
--log-format tracing-fullOutputs traces in the tracing library's
Fullstyle. Useful in conjunction with the--verboseflag to debug issues.--verbosedrops the log level to debug and outputs all Nix logs.Introduces:
DevenvLayertracing layer that tracks metadata about spans. This tracks span timings, errors, and emits events when the span is created and closed.DevenvFormatevent formatter that mimics the existing CLI formatting.