Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devenv-run-tests: switch directories in between tests #1599

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Conversation

sandydoo
Copy link
Member

No description provided.

Copy link

cloudflare-workers-and-pages bot commented Nov 19, 2024

Deploying devenv with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5fbd554
Status: ✅  Deploy successful!
Preview URL: https://37acaaef.devenv.pages.dev
Branch Preview URL: https://fix-wasm-test.devenv.pages.dev

View logs

@sandydoo
Copy link
Member Author

I've figured out what's going on with this test. git-hooks installs the hooks in the git root dir, so the test/example hooks end up running against the whole devenv repo.
Either we add some tweakable option to git-hooks, or we could cp the whole directory with the test/example to tmp, run git init, and do our stuff without worry.

@domenkozar
Copy link
Member

Maybe we just need to git init?

@domenkozar domenkozar closed this Nov 24, 2024
@domenkozar domenkozar reopened this Nov 24, 2024
@sandydoo
Copy link
Member Author

Maybe we just need to git init?

Yes, but it would be best to do so in a temporary directory.

@sandydoo sandydoo marked this pull request as ready for review November 25, 2024 14:43
@sandydoo
Copy link
Member Author

This doesn't fully fix the wasm test, but it's a good cleanup to merge.

@domenkozar domenkozar merged commit a7125d2 into main Nov 25, 2024
528 of 568 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants