Add just_left_then_away mode, and other cleanup #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a version to the manifest.json for compatibility with 2021.6. Fixes cadavre#1
|
Thanks for this PR! It was one of my first Python components so many things to be fixed, and you did it! If you can confirm that it works well then I'll merge. I'm not using this component anymore, because I moved to NodeRED. |
|
I can confirm that it works; I've been using it for a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The biggest feature here is the addition of
just_left_then_awaymode. This is useful, for example, the case where an alarm system is being armed to Away. If someone is just detected as having left, notify them. But if no one is detected as having just left, notify everyone who is away.I've done some code and terminology cleanup here as well. (The term "inmates" typically refers to prisoners—not the best description of use case here, I imagine.)