Add defer putLengthReader to prevent leak

Signed-off-by: Harish Shan <140232061+perhapsmaple@users.noreply.github.com>
caddyserver · Oct 2, 2023 · 2c9d8eb · 2c9d8eb
1 parent 3edc716
commit 2c9d8eb
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/modules/caddyhttp/server.go b/modules/caddyhttp/server.go
@@ -320,6 +320,7 @@ func (s *Server) ServeHTTP(w http.ResponseWriter, r *http.Request) {
 		var bodyReader *lengthReader
 		if r.Body != nil {
 			bodyReader = getLengthReader(r.Body)
+			defer putLengthReader(bodyReader)
 			r.Body = bodyReader
 		}
 
@@ -728,7 +729,6 @@ func (s *Server) logRequest(
 	reqBodyLength := 0
 	if bodyReader != nil {
 		reqBodyLength = bodyReader.Length
-		putLengthReader(bodyReader)
 	}
 
 	extra := r.Context().Value(ExtraLogFieldsCtxKey).(*ExtraLogFields)