headers: Trim any trailing colon from field names as a courtesy

caddyserver · Mar 30, 2020 · 37aa516 · 37aa516
1 parent 105acfa
commit 37aa516
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/modules/caddyhttp/headers/caddyfile.go b/modules/caddyhttp/headers/caddyfile.go
@@ -111,6 +111,12 @@ func parseReqHdrCaddyfile(h httpcaddyfile.Helper) (caddyhttp.MiddlewareHandler,
 			return nil, h.ArgErr()
 		}
 		field := h.Val()
+
+		// sometimes it is habitual for users to suffix a field name with a colon,
+		// as if they were writing a curl command or something; see
+		// https://caddy.community/t/v2-reverse-proxy-please-add-cors-example-to-the-docs/7349
+		field = strings.TrimSuffix(field, ":")
+
 		var value, replacement string
 		if h.NextArg() {
 			value = h.Val()