-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
go.mod: Replace promptui with Apache-compatible fork (fix #4394)
Ideally this needs to be fixed upstream in github.com/manifoldco/promptui, but it appears unmaintained. Our dependency is extremely indirect: $ go mod why github.com/juju/ansiterm # github.com/juju/ansiterm github.com/caddyserver/caddy/v2/modules/caddypki github.com/smallstep/certificates/authority go.step.sm/cli-utils/ui github.com/manifoldco/promptui github.com/juju/ansiterm And it appears that all dependencies in this chain are in conflict with the LGPL license. Ref: - manifoldco/promptui#173 - manifoldco/promptui#181 /cc @maraino
- Loading branch information
Showing
2 changed files
with
6 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
997e41d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mholt. I would use the fork.
997e41d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maraino Do you mean that Smallstep will use the fork? (If so, we can probably remove this replace in Caddy)
997e41d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maraino @mholt I don't think using the replace upstream works. Per the Modules wiki:
997e41d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mohammed90 We're discussing in Slack now; Smallstep has a direct dependency on promptui so they can change the
require
line to use the fork; I am not sure why they need areplace
.Edit: It's because the fork didn't update its go.mod file, sigh. Ideally the original repo would just fix the problem.
997e41d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've pinged @manifoldco through a friend, let's see if they respond.
And @jbowes do you still have commit rights?