-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ci: Ensure we always check for latest version of Go (#4703)
* ci: Ensure we always check for latest version of Go * Try to force 1.18.1, 1.17.9 * Use includes for the actual go semver * Use `~` for semver here, apparently * Try to make tests still run on 1.18.0 for Mac, for now
- Loading branch information
1 parent
30b6d1f
commit c3a82f5
Showing
4 changed files
with
36 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,10 +21,23 @@ jobs: | |
os: [ ubuntu-latest, macos-latest, windows-latest ] | ||
go: [ '1.17', '1.18' ] | ||
|
||
include: | ||
# Set the minimum Go patch version for the given Go minor | ||
# Usable via ${{ matrix.GO_SEMVER }} | ||
- go: '1.17' | ||
GO_SEMVER: '~1.17.9' | ||
|
||
- go: '1.18' | ||
GO_SEMVER: '~1.18.1' | ||
|
||
# Go 1.18.1 isn't released yet for Mac as of Apr 13 2022 | ||
- go: '1.18' | ||
os: 'macos-latest' | ||
GO_SEMVER: '1.18.0' | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
emilylange
Member
|
||
|
||
# Set some variables per OS, usable via ${{ matrix.VAR }} | ||
# CADDY_BIN_PATH: the path to the compiled Caddy binary, for artifact publishing | ||
# SUCCESS: the typical value for $? per OS (Windows/pwsh returns 'True') | ||
include: | ||
- os: ubuntu-latest | ||
CADDY_BIN_PATH: ./cmd/caddy/caddy | ||
SUCCESS: 0 | ||
|
@@ -43,7 +56,8 @@ jobs: | |
- name: Install Go | ||
uses: actions/setup-go@v3 | ||
with: | ||
go-version: ${{ matrix.go }} | ||
go-version: ${{ matrix.GO_SEMVER }} | ||
check-latest: true | ||
|
||
- name: Checkout code | ||
uses: actions/checkout@v3 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@francislavoie we can bump that now, no?
https://www.reddit.com/r/golang/comments/u483il/go_1181_is_out_for_macos/