AIX build is broken #5970

bmarwell · 2023-12-11T09:26:51Z

Hi,

I just noticed the env vars GOOS=aix GOARCH=ppc64 will lead to a build error:

$ GOOS=aix GOARCH=ppc64 go build
# github.com/dgraph-io/badger
../../../../go/pkg/mod/github.com/dgraph-io/badger@v1.6.2/dir_unix.go:63:13: undefined: unix.Flock
# github.com/dgraph-io/badger/v2
../../../../go/pkg/mod/github.com/dgraph-io/badger/v2@v2.2007.4/dir_unix.go:62:13: undefined: unix.Flock
# github.com/google/certificate-transparency-go/x509
../../../../go/pkg/mod/github.com/google/certificate-transparency-go@v1.1.6/x509/cert_pool.go:65:9: undefined: loadSystemRoots
../../../../go/pkg/mod/github.com/google/certificate-transparency-go@v1.1.6/x509/root.go:21:32: undefined: loadSystemRoots
../../../../go/pkg/mod/github.com/google/certificate-transparency-go@v1.1.6/x509/verify.go:759:12: c.systemVerify undefined (type *Certificate has no field or method systemVerify)

I think this should have worked out of the box? => https://gist.github.com/asukakenji/f15ba7e588ac42795f421b48b8aede63

I found no infos about AIX not being supported. Any help is appreciated.

The text was updated successfully, but these errors were encountered:

bmarwell · 2023-12-11T09:29:05Z

Just for reference, other not-so-common platforms work fine, too.

~/git/caddy-2.7.6-src/caddy ⌚ 10:25:19
$ GOOS=linux GOARCH=ppc64le go build

~/git/caddy-2.7.6-src/caddy ⌚ 10:27:32
$ file caddy
caddy: ELF 64-bit LSB executable, 64-bit PowerPC or cisco 7500, OpenPOWER ELF V2 ABI, version 1 (SYSV), statically linked, Go BuildID=G8uALCkYZAyhWc4CyD6c/zliuk-1icIxIIpa3eOMl/vI3N5kg7rx6eOf2RfoYl/on9sJjH1QcQMdAMjc8O0, with debug_info, not stripped

~/git/caddy-2.7.6-src/caddy ⌚ 10:27:34
$ GOOS=linux GOARCH=s390x go build

~/git/caddy-2.7.6-src/caddy ⌚ 10:27:53
$ file caddy
caddy: ELF 64-bit MSB executable, IBM S/390, version 1 (SYSV), statically linked, Go BuildID=mkeLzHm9-bugelmaRTtG/PPW-2hvu4VfD7pgOy9Wu/97vrcGdc2E5OZK_rR8Rq/bXuMaIM1H6bX4ZVQfbd7, with debug_info, not stripped

francislavoie · 2023-12-11T09:37:41Z

I've never even heard of aix. We're not testing for that in our crossbuild job https://github.com/caddyserver/caddy/blob/master/.github/workflows/cross-build.yml

Either way, this is a problem with upstream dependencies. You'll probably need to get the attention of dgraph-io/badger and google/certificate-transparency-go to fix it.

mohammed90 · 2023-12-11T09:40:23Z

For badger, the issue is a gap further upstream in golang.org/x/sys/unix, which is missing some syscalls for AIX, notably Lock.

bmarwell · 2023-12-11T10:06:35Z

I really do not know what to do here. If you would like to help me out, you'd need to create upstream issues for this -- sorry! (and thanks for the quick analysis!).

mohammed90 · 2023-12-11T10:19:47Z

I really do not know what to do here. If you would like to help me out, you'd need to create upstream issues for this -- sorry! (and thanks for the quick analysis!).

Just so we know the use case, are you trying to use Caddy on AIX, or just mere curiosity?

bmarwell · 2023-12-11T10:31:59Z

Just so we know the use case, are you trying to use Caddy on AIX, or just mere curiosity?

I would like to evaluate different web- and reverse-proxy servers for a few use cases. But AIX is a must-have for me for inclusion into my compatibility matrix. But in terms of use-case, it is just a proof-of-concept, so something in-between, probably.

bmarwell · 2023-12-11T12:21:20Z

I've never even heard of aix. We're not testing for that in our crossbuild job https://github.com/caddyserver/caddy/blob/master/.github/workflows/cross-build.yml

Either way, this is a problem with upstream dependencies. You'll probably need to get the attention of dgraph-io/badger and google/certificate-transparency-go to fix it.

Oh, I can add a PR for that! #5971
Let me just find and sign the CLA form. 😊

mohammed90 · 2023-12-12T10:49:36Z

Reported upstream:

mholt · 2023-12-12T23:56:28Z

We might have to defer this as I think this is largely out of our control. It looks like AIX simply does not support the API needed. But with the tag we can revisit this more easily. Thanks for reporting!

Closing because there's nothing actionable we can do right now (more than Mohammed has done), as far as I know... but feel free to continue discussion.

mohammed90 · 2024-01-10T13:05:24Z

@bmarwell, you can use the build tag nobadger to build Caddy on AIX. We don't use Badger anyways; we use bbolt, which works on AIX without issues.

bmarwell · 2024-01-10T17:17:46Z

Thanks, will try! The docs didn't mention this, at least not on the front page.

bmarwell · 2024-01-10T17:24:36Z

Hi @mohammed90

build tag nobadger to build Caddy ...

... how do I do that? Note, I'm not using xcaddy. Haven't found "build tag",
nor "nobadger" in the docs.

mohammed90 · 2024-01-10T17:50:54Z

Thanks, will try! The docs didn't mention this, at least not on the front page.

Yeah, it wasn't clear on our dependency's repository until I went through their source code.

how do I do that? Note, I'm not using xcaddy

"build tags" are a Go thing, not xcaddy thing. Inside cmd/caddy, run this:

GOOS=aix GOARCH=ppc64 go build -tags nobadger

Note that you'll have to build with the ~~branch add-nobadger-tag (created for PR #6031)~~ HEAD (now merged) because we need a transient dependency (which isn't in our execution path 🤷) to be upgraded to HEAD.

bmarwell · 2024-01-10T19:39:14Z

Woohoo thanks! Can now evaulate caddy as a reverse proxy! Many thanks! 👍🏻

bmarwell · 2024-01-11T07:50:44Z

@mohammed90 how did you get around these error messages?

$ GOOS=aix GOARCH=ppc64 go build -v -tags nobadger -trimpath -o caddy.aix.ppc64-debug
github.com/google/certificate-transparency-go/x509
# github.com/google/certificate-transparency-go/x509
../../../../go/pkg/mod/github.com/google/certificate-transparency-go@v1.1.6/x509/cert_pool.go:65:9: undefined: loadSystemRoots
../../../../go/pkg/mod/github.com/google/certificate-transparency-go@v1.1.6/x509/root.go:21:32: undefined: loadSystemRoots
../../../../go/pkg/mod/github.com/google/certificate-transparency-go@v1.1.6/x509/verify.go:759:12: c.systemVerify undefined (type *Certificate has no field or method systemVerify)

mohammed90 · 2024-01-11T07:54:23Z

@mohammed90 how did you get around these error messages?

$ GOOS=aix GOARCH=ppc64 go build -v -tags nobadger -trimpath -o caddy.aix.ppc64-debug
github.com/google/certificate-transparency-go/x509
# github.com/google/certificate-transparency-go/x509
../../../../go/pkg/mod/github.com/google/certificate-transparency-go@v1.1.6/x509/cert_pool.go:65:9: undefined: loadSystemRoots
../../../../go/pkg/mod/github.com/google/certificate-transparency-go@v1.1.6/x509/root.go:21:32: undefined: loadSystemRoots
../../../../go/pkg/mod/github.com/google/certificate-transparency-go@v1.1.6/x509/verify.go:759:12: c.systemVerify undefined (type *Certificate has no field or method systemVerify)

You have to build from the commit b359ca5 because we had to upgrade github.com/google/certificate-transparency-go dependency to HEAD as well.

Basically, if you git-cloned Caddy, do git pull origin master then build from there.

bmarwell · 2024-01-11T07:55:47Z

I just used master. Then did the following:

Create a new folder: mkdir caddy
Change into it: cd caddy
Copy Caddy's main.go into the empty folder.
Initialize a Go module: go mod init caddy
Did go mod tidy

Compile: go build like above

mohammed90 · 2024-01-11T07:58:41Z

I just used master. Then did the following:

Create a new folder: mkdir caddy

Change into it: cd caddy

Copy Caddy's main.go into the empty folder.

Initialize a Go module: go mod init caddy

Did go mod tidy

Compile: go build like above

Oh, you'll have to run go get -u github.com/caddyserver/caddy/v2@master after the tidy step.

bmarwell · 2024-01-11T07:58:49Z

Oh I think I need to execute go get github.com/caddyserver/caddy/v2@ although it says optional step. However, according to go, the step is not optional.

bmarwell · 2024-01-11T07:59:46Z

Oh, you'll have to run go get -u github.com/caddyserver/caddy/v2@master after the tidy step.

Yup than the readme is not 100% correct. Instead of making the "go get" step optional, it should mention when to use it. And if you don't use it, you'd need go mod tidy.

mohammed90 · 2024-01-11T08:01:27Z

Oh, you'll have to run go get -u github.com/caddyserver/caddy/v2@master after the tidy step.

Yup than the readme is not 100% correct. Instead of making the "go get" step optional, it should mention when to use it. And if you don't use it, you'd need go mod tidy.

The README is correct because it's listing the typical workflow of building the latest tagged version without modification. The change in flow for you is because you're trying to build an untagged version that has not been released yet. Once we tag a new version, you won't need to do the go get -u ....

bmarwell · 2024-01-11T08:08:33Z

Thank you for your patience explaining this! :) I am a Java developer only, all of what you said is really helpful! 👍🏻

francislavoie added the upstream ⬆️ Relates to some dependency of this project label Dec 11, 2023

bmarwell added a commit to bmarwell/caddy that referenced this issue Dec 11, 2023

[caddyserver#5970] cross-build for AIX

1a42982

bmarwell mentioned this issue Dec 11, 2023

chore: cross-build for AIX #5971

Merged

This was referenced Dec 12, 2023

x/sys/unix: missing some AIX syscalls, notably Flock golang/go#64669

Open

[BUG]: compilation fails with GOOS=aix (Unix) dgraph-io/badger#2035

Open

Compilation Failure on GOOS=aix google/certificate-transparency-go#1276

Closed

mholt closed this as not planned Won't fix, can't repro, duplicate, stale Dec 12, 2023

mholt added the deferred ⏰ We'll come back to this later label Dec 12, 2023

francislavoie mentioned this issue Feb 11, 2024

acmeserver: support additional database types beside bbolt #6097

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AIX build is broken #5970

AIX build is broken #5970

bmarwell commented Dec 11, 2023

bmarwell commented Dec 11, 2023 •

edited

Loading

francislavoie commented Dec 11, 2023

mohammed90 commented Dec 11, 2023

bmarwell commented Dec 11, 2023

mohammed90 commented Dec 11, 2023

bmarwell commented Dec 11, 2023

bmarwell commented Dec 11, 2023

mohammed90 commented Dec 12, 2023

mholt commented Dec 12, 2023 •

edited

Loading

mohammed90 commented Jan 10, 2024

bmarwell commented Jan 10, 2024

bmarwell commented Jan 10, 2024

mohammed90 commented Jan 10, 2024 •

edited

Loading

bmarwell commented Jan 10, 2024

bmarwell commented Jan 11, 2024

mohammed90 commented Jan 11, 2024

bmarwell commented Jan 11, 2024 •

edited

Loading

mohammed90 commented Jan 11, 2024

bmarwell commented Jan 11, 2024

bmarwell commented Jan 11, 2024

mohammed90 commented Jan 11, 2024

bmarwell commented Jan 11, 2024

AIX build is broken #5970

AIX build is broken #5970

Comments

bmarwell commented Dec 11, 2023

bmarwell commented Dec 11, 2023 • edited Loading

francislavoie commented Dec 11, 2023

mohammed90 commented Dec 11, 2023

bmarwell commented Dec 11, 2023

mohammed90 commented Dec 11, 2023

bmarwell commented Dec 11, 2023

bmarwell commented Dec 11, 2023

mohammed90 commented Dec 12, 2023

mholt commented Dec 12, 2023 • edited Loading

mohammed90 commented Jan 10, 2024

bmarwell commented Jan 10, 2024

bmarwell commented Jan 10, 2024

mohammed90 commented Jan 10, 2024 • edited Loading

bmarwell commented Jan 10, 2024

bmarwell commented Jan 11, 2024

mohammed90 commented Jan 11, 2024

bmarwell commented Jan 11, 2024 • edited Loading

mohammed90 commented Jan 11, 2024

bmarwell commented Jan 11, 2024

bmarwell commented Jan 11, 2024

mohammed90 commented Jan 11, 2024

bmarwell commented Jan 11, 2024

bmarwell commented Dec 11, 2023 •

edited

Loading

mholt commented Dec 12, 2023 •

edited

Loading

mohammed90 commented Jan 10, 2024 •

edited

Loading

bmarwell commented Jan 11, 2024 •

edited

Loading