-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reverseproxy: always set the req.URL.Host with the upstream #3290
Conversation
Feng Xi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Thanks for the PR! I don't know what I was thinking when I wrote that It makes sense to remove it, since if the first request fails, it will try with the second backend, but the req.URL.Host will already be set to the host of the first backend 🤔 So... I do think this fixes a bug. It's a pretty minor change, and I've confirmed it works in a few various configurations, and you've confirmed it works for you, too. I think we can get this out in v2.0. Any objections? @francislavoie @sarge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me.
@westwin Before we can merge, we need you to sign the CLA. |
Looks fine to me:) |
@westwin for the CLA, you'll need to either add your email address |
I've re-submitted as I used a fake email address in my git config, see #3297 sorry for the inconvenience |
Issue Description: reverse proxy with round-robin policy always forwards the traffic to one upstream node.
How to Reproduce:
:2015 {
reverse_proxy /* 127.0.0.1:9010 127.0.0.1:9020 {
lb_policy round_robin
lb_try_duration 100ms
lb_try_interval 250ms
}
}
Test on macos