Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caddyhttp: Fix common_log format's user ID placeholder #3300

Merged
merged 1 commit into from
Apr 22, 2020

Conversation

francislavoie
Copy link
Member

@francislavoie francislavoie commented Apr 22, 2020

I was digging around for the http.auth.user.id placeholder in the code and noticed that the common_log format was using the wrong placeholder.

@francislavoie francislavoie requested a review from mholt April 22, 2020 14:17
@francislavoie francislavoie added the bug 🐞 Something isn't working label Apr 22, 2020
@francislavoie francislavoie added this to the v2.0.0 milestone Apr 22, 2020
@francislavoie
Copy link
Member Author

As an aside, I don't think {http.auth.user.id} is documented anywhere. That should probably be added in a couple different spots (basicauth directive and in the authentication module docs I figure)

@mholt
Copy link
Member

mholt commented Apr 22, 2020

Thanks for the fix!

You are right that it's not documented anywhere -- yet; this is intentional as the auth features aren't really finished/set in stone yet, but there's some good progress on auth plugins coming along by the community so I think we can document them better soon enough!

@mholt mholt merged commit bacf50a into caddyserver:master Apr 22, 2020
@francislavoie francislavoie deleted the common-log-user branch April 22, 2020 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants