Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caddyhttp: reverse-proxy command add --insecure flag #3389

Merged
merged 1 commit into from
May 12, 2020

Conversation

linquize
Copy link
Contributor

caddyhttp: reverse-proxy command add --insecure flag

Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I'm OK with this option but I do think the help text could be clarified. ... I have such mixed feelings about this option, so I don't like making it easy to access. I guess if we must, we should be loud about it.

@mholt mholt added the under review 🧐 Review is pending before merging label May 11, 2020
@linquize linquize force-pushed the reverse-proxy-insecure branch from 9b544e5 to 7468d38 Compare May 12, 2020 16:25
@linquize linquize force-pushed the reverse-proxy-insecure branch from 7468d38 to 1106804 Compare May 12, 2020 16:26
@mholt mholt removed the under review 🧐 Review is pending before merging label May 12, 2020
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! That should scare off any unsuspecting users 😏

@mholt mholt merged commit 44536a7 into caddyserver:master May 12, 2020
@linquize linquize deleted the reverse-proxy-insecure branch May 12, 2020 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants