caddytest: Refactor Caddyfile adapt tests to separate files #3398
+592
−573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarge
reviewed
May 12, 2020
|
LGTM |
sarge
approved these changes
May 13, 2020
mholt
approved these changes
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to refactor the Caddyfile adapt tests from the one big file to a directory of text files with Caddyfile input and JSON output, separated by
----------(10 dashes).Should make it easier to read and edit tests, and we'll avoid the constant merge conflicts between MRs that keep trying to modify that test file 😛
I'm sorry that the diff looks super wacky on this one. Git doesn't like it lol