Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reverseproxy: Apply response header ops before copying it (fix #3382) #3401

Merged
merged 1 commit into from
May 13, 2020
Merged

reverseproxy: Apply response header ops before copying it (fix #3382) #3401

merged 1 commit into from
May 13, 2020

Conversation

mholt
Copy link
Member

@mholt mholt commented May 12, 2020

I confirmed that this fixes #3382. Thanks for the report @MexHigh - please try this out. There are build artifacts available in the Actions / CI.

@mholt mholt added this to the 2.1 milestone May 12, 2020
@mholt mholt mentioned this pull request May 12, 2020
Closed
MexHigh
MexHigh approved these changes May 13, 2020
View reviewed changes
Copy link

@MexHigh MexHigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for my configuration now (mentioned in #3382)

@mholt mholt merged commit 90c7b4b into master May 13, 2020
@mholt
Copy link
Member Author

mholt commented May 13, 2020

Great, thanks!

@mholt mholt deleted the issue3382 branch May 13, 2020 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MexHigh MexHigh MexHigh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging this pull request may close these issues.

v2: header_down removes headers added by caddy too
2 participants
@mholt @MexHigh