Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encode: Drop prefer from Caddyfile #4156

Merged
merged 1 commit into from
May 10, 2021
Merged

encode: Drop prefer from Caddyfile #4156

merged 1 commit into from
May 10, 2021

Conversation

francislavoie
Copy link
Member

Followup to #4150, #4151 /cc @ueffel @polarathene

After a bit of discussion with @mholt, we decided to remove prefer as a subdirective and just go with using the order implicitly always. Simpler config, simpler docs, etc.

@francislavoie francislavoie added this to the v2.4.0 milestone May 10, 2021
@francislavoie francislavoie requested a review from mholt May 10, 2021 16:31
Followup to #4150, #4151 /cc @ueffel @polarathene

After a bit of discussion with @mholt, we decided to remove `prefer` as a subdirective and just go with using the order implicitly always. Simpler config, simpler docs, etc.
@mholt
Copy link
Member

mholt commented May 10, 2021

Effectively reverts 7776471 and a small part of f35a7fa.

Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much better. Thank you!

@mholt mholt merged commit f5db41c into master May 10, 2021
@mholt mholt deleted the encode-prefer branch May 10, 2021 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants