Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4644
Metrics have accumulated an unfortunate performance regression and have some functionality limitations. Since we don't have the time or expertise on hand currently to address these issues in the more ideal way, I think we need to make metrics opt-in for now.
In the JSON, metrics are enabled by setting
"metrics": {}
in your server config, or in the Caddyfile, use global options:This is EXPERIMENTAL and subject to change.
Note that metrics for
handle_response
handlers (etc) will not be able to have metrics enabled, at least for now.I think going forward a better long-term fix might be to have the
metrics
directive enable metrics, rather than a server-wide config. I'd also like to make certain aspects about metrics actually configurable, rather than having an empty struct.