ci: Fix goreleaser deprecation #5270

francislavoie · 2022-12-28T03:22:20Z

See https://goreleaser.com/deprecations/#archivesreplacements

I took the default for name_template documented at https://goreleaser.com/customization/archive/?h=archive#archives, turned it into a multi-line string using the "After" tab from https://goreleaser.com/deprecations/#archivesreplacements, then changed {{ .Os }} to be wrapped by an if darwin outputting mac instead.

Technically untested, the goreleaser_check seems to pass now but I didn't run it to see if the template has the expected result. I don't have it installed locally etc so would appreciate if you could test it out @mohammed90 😊

mohammed90

Thanks for the prompt fix! Here's the output of TAG=v2.6.2 goreleaser release --snapshot --skip-announce --skip-docker --skip-publish --skip-sbom --skip-sign --rm-dist:

dist/caddy_2.6.2-SNAPSHOT-b1814345_linux_amd64.deb
dist/caddy_2.6.2-SNAPSHOT-b1814345_linux_amd64.tar.gz
dist/caddy_2.6.2-SNAPSHOT-b1814345_linux_arm64.deb
dist/caddy_2.6.2-SNAPSHOT-b1814345_linux_arm64.tar.gz
dist/caddy_2.6.2-SNAPSHOT-b1814345_linux_armv5.deb
dist/caddy_2.6.2-SNAPSHOT-b1814345_linux_armv5.tar.gz
dist/caddy_2.6.2-SNAPSHOT-b1814345_linux_armv6.deb
dist/caddy_2.6.2-SNAPSHOT-b1814345_linux_armv6.tar.gz
dist/caddy_2.6.2-SNAPSHOT-b1814345_linux_armv7.deb
dist/caddy_2.6.2-SNAPSHOT-b1814345_linux_armv7.tar.gz
dist/caddy_2.6.2-SNAPSHOT-b1814345_linux_ppc64le.deb
dist/caddy_2.6.2-SNAPSHOT-b1814345_linux_ppc64le.tar.gz
dist/caddy_2.6.2-SNAPSHOT-b1814345_mac_amd64.tar.gz
dist/caddy_2.6.2-SNAPSHOT-b1814345_mac_arm64.tar.gz

That output was possible after fixing the {{ - thing 🙂

.goreleaser.yml

emilylange · 2022-12-28T09:37:26Z

List of archives using the command @mohammed90 shared:

caddy_2.6.2-SNAPSHOT-580ccb84_freebsd_amd64.tar.gz
caddy_2.6.2-SNAPSHOT-580ccb84_freebsd_arm64.tar.gz
caddy_2.6.2-SNAPSHOT-580ccb84_freebsd_armv6.tar.gz
caddy_2.6.2-SNAPSHOT-580ccb84_freebsd_armv7.tar.gz
caddy_2.6.2-SNAPSHOT-580ccb84_linux_amd64.deb
caddy_2.6.2-SNAPSHOT-580ccb84_linux_amd64.tar.gz
caddy_2.6.2-SNAPSHOT-580ccb84_linux_arm64.deb
caddy_2.6.2-SNAPSHOT-580ccb84_linux_arm64.tar.gz
caddy_2.6.2-SNAPSHOT-580ccb84_linux_armv5.deb
caddy_2.6.2-SNAPSHOT-580ccb84_linux_armv5.tar.gz
caddy_2.6.2-SNAPSHOT-580ccb84_linux_armv6.deb
caddy_2.6.2-SNAPSHOT-580ccb84_linux_armv6.tar.gz
caddy_2.6.2-SNAPSHOT-580ccb84_linux_armv7.deb
caddy_2.6.2-SNAPSHOT-580ccb84_linux_armv7.tar.gz
caddy_2.6.2-SNAPSHOT-580ccb84_linux_ppc64le.deb
caddy_2.6.2-SNAPSHOT-580ccb84_linux_ppc64le.tar.gz
caddy_2.6.2-SNAPSHOT-580ccb84_linux_s390x.deb
caddy_2.6.2-SNAPSHOT-580ccb84_linux_s390x.tar.gz
caddy_2.6.2-SNAPSHOT-580ccb84_mac_amd64.tar.gz
caddy_2.6.2-SNAPSHOT-580ccb84_mac_arm64.tar.gz
caddy_2.6.2-SNAPSHOT-580ccb84_windows_amd64.zip
caddy_2.6.2-SNAPSHOT-580ccb84_windows_arm64.zip
caddy_2.6.2-SNAPSHOT-580ccb84_windows_armv5.zip
caddy_2.6.2-SNAPSHOT-580ccb84_windows_armv6.zip
caddy_2.6.2-SNAPSHOT-580ccb84_windows_armv7.zip

emilylange

I just noticed that the .sboms for darwin/mac use _darwin_ instead of _mac_¹.

caddy/.goreleaser.yml

Line 78 in b166b90

    
           - '{{ .Binary }}_{{ .Version }}_{{ .Os }}_{{ .Arch }}{{if .Arm}}v{{ .Arm }}{{end}}.sbom'

I couldn't find a way to use a variable instead of copy pasting the templating, but

    documents:
    - >-
      {{ .ProjectName }}_
      {{- .Version }}_
      {{- if eq .Os "darwin" }}mac{{ else }}{{ .Os }}{{ end }}_
      {{- .Arch }}
      {{- with .Arm }}v{{ . }}{{ end }}
      {{- with .Mips }}_{{ . }}{{ end }}
      {{- if not (eq .Amd64 "v1") }}{{ .Amd64 }}{{ end }}.sbom
    cmd: syft

works and makes the .sboms follow the archives' names.

Can be seen in https://github.com/caddyserver/caddy/releases/tag/v2.6.2 ↩

mohammed90 · 2022-12-28T10:21:00Z

I just noticed that the .sboms for darwin/mac use _darwin_ instead of _mac_1.

caddy/.goreleaser.yml

Line 78 in b166b90

- '{{ .Binary }}_{{ .Version }}_{{ .Os }}_{{ .Arch }}{{if .Arm}}v{{ .Arm }}{{end}}.sbom'

I couldn't find a way to use a variable instead of copy pasting the templating, but
    documents:
    - >-
      {{ .ProjectName }}_
      {{- .Version }}_
      {{- if eq .Os "darwin" }}mac{{ else }}{{ .Os }}{{ end }}_
      {{- .Arch }}
      {{- with .Arm }}v{{ . }}{{ end }}
      {{- with .Mips }}_{{ . }}{{ end }}
      {{- if not (eq .Amd64 "v1") }}{{ .Amd64 }}{{ end }}.sbom
    cmd: syft
works and makes the .sboms follow the archives' names.

Footnotes
1. Can be seen in https://github.com/caddyserver/caddy/releases/tag/v2.6.2 [↩](#user-content-fnref-1-cc6ad68b02163209145680033a5e8148)

Good catch!

francislavoie · 2022-12-28T16:28:01Z

Thanks guys.

Final 👍 before I merge?

emilylange

All good 👍

Outputs:

caddy_2.6.2-SNAPSHOT-91554ed7_freebsd_amd64.sbom
caddy_2.6.2-SNAPSHOT-91554ed7_freebsd_amd64.tar.gz
caddy_2.6.2-SNAPSHOT-91554ed7_freebsd_arm64.sbom
caddy_2.6.2-SNAPSHOT-91554ed7_freebsd_arm64.tar.gz
caddy_2.6.2-SNAPSHOT-91554ed7_freebsd_armv6.sbom
caddy_2.6.2-SNAPSHOT-91554ed7_freebsd_armv6.tar.gz
caddy_2.6.2-SNAPSHOT-91554ed7_freebsd_armv7.sbom
caddy_2.6.2-SNAPSHOT-91554ed7_freebsd_armv7.tar.gz
caddy_2.6.2-SNAPSHOT-91554ed7_linux_amd64.deb
caddy_2.6.2-SNAPSHOT-91554ed7_linux_amd64.sbom
caddy_2.6.2-SNAPSHOT-91554ed7_linux_amd64.tar.gz
caddy_2.6.2-SNAPSHOT-91554ed7_linux_arm64.deb
caddy_2.6.2-SNAPSHOT-91554ed7_linux_arm64.sbom
caddy_2.6.2-SNAPSHOT-91554ed7_linux_arm64.tar.gz
caddy_2.6.2-SNAPSHOT-91554ed7_linux_armv5.deb
caddy_2.6.2-SNAPSHOT-91554ed7_linux_armv5.sbom
caddy_2.6.2-SNAPSHOT-91554ed7_linux_armv5.tar.gz
caddy_2.6.2-SNAPSHOT-91554ed7_linux_armv6.deb
caddy_2.6.2-SNAPSHOT-91554ed7_linux_armv6.sbom
caddy_2.6.2-SNAPSHOT-91554ed7_linux_armv6.tar.gz
caddy_2.6.2-SNAPSHOT-91554ed7_linux_armv7.deb
caddy_2.6.2-SNAPSHOT-91554ed7_linux_armv7.sbom
caddy_2.6.2-SNAPSHOT-91554ed7_linux_armv7.tar.gz
caddy_2.6.2-SNAPSHOT-91554ed7_linux_ppc64le.deb
caddy_2.6.2-SNAPSHOT-91554ed7_linux_ppc64le.sbom
caddy_2.6.2-SNAPSHOT-91554ed7_linux_ppc64le.tar.gz
caddy_2.6.2-SNAPSHOT-91554ed7_linux_s390x.deb
caddy_2.6.2-SNAPSHOT-91554ed7_linux_s390x.sbom
caddy_2.6.2-SNAPSHOT-91554ed7_linux_s390x.tar.gz
caddy_2.6.2-SNAPSHOT-91554ed7_mac_amd64.sbom
caddy_2.6.2-SNAPSHOT-91554ed7_mac_amd64.tar.gz
caddy_2.6.2-SNAPSHOT-91554ed7_mac_arm64.sbom
caddy_2.6.2-SNAPSHOT-91554ed7_mac_arm64.tar.gz
caddy_2.6.2-SNAPSHOT-91554ed7_windows_amd64.sbom
caddy_2.6.2-SNAPSHOT-91554ed7_windows_amd64.zip
caddy_2.6.2-SNAPSHOT-91554ed7_windows_arm64.sbom
caddy_2.6.2-SNAPSHOT-91554ed7_windows_arm64.zip
caddy_2.6.2-SNAPSHOT-91554ed7_windows_armv5.sbom
caddy_2.6.2-SNAPSHOT-91554ed7_windows_armv5.zip
caddy_2.6.2-SNAPSHOT-91554ed7_windows_armv6.sbom
caddy_2.6.2-SNAPSHOT-91554ed7_windows_armv6.zip
caddy_2.6.2-SNAPSHOT-91554ed7_windows_armv7.sbom
caddy_2.6.2-SNAPSHOT-91554ed7_windows_armv7.zip

mholt · 2022-12-28T20:14:26Z

You guys are incredible. Thanks for this and everything else you do!

See caddyserver/caddy#5270 where we made this change for Caddy

francislavoie added the CI/CD 🔩 Automated tests, releases label Dec 28, 2022

francislavoie added this to the v2.6.3 milestone Dec 28, 2022

francislavoie requested a review from mohammed90 December 28, 2022 03:22

francislavoie mentioned this pull request Dec 28, 2022

reverseproxy: Don't enable auto-https when --from flag is http #5269

Merged

mohammed90 requested changes Dec 28, 2022

View reviewed changes

.goreleaser.yml Outdated Show resolved Hide resolved

mohammed90 approved these changes Dec 28, 2022

View reviewed changes

emilylange suggested changes Dec 28, 2022

View reviewed changes

francislavoie mentioned this pull request Dec 28, 2022

ci: Update GitHub Actions to avoid set-output deprecation #5271

Merged

emilylange approved these changes Dec 28, 2022

View reviewed changes

francislavoie added 3 commits December 28, 2022 12:52

Update .goreleaser.yml

f5a3cfc

Fix newline stripping thing

8f5e424

Update sboms filename

aec1ba8

francislavoie force-pushed the goreleaser-deprecation-fix branch from 91554ed to aec1ba8 Compare December 28, 2022 17:52

mohammed90 approved these changes Dec 28, 2022

View reviewed changes

francislavoie merged commit b40548f into master Dec 28, 2022

francislavoie deleted the goreleaser-deprecation-fix branch December 28, 2022 18:11

francislavoie added a commit to caddyserver/xcaddy that referenced this pull request Jan 21, 2023

ci: Fix goreleaser

51ade00

See caddyserver/caddy#5270 where we made this change for Caddy

emilylange mentioned this pull request Feb 8, 2023

ci: enable dependabot to keep Actions versions up-to-date caddyserver/xcaddy#133

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: Fix goreleaser deprecation #5270

ci: Fix goreleaser deprecation #5270

francislavoie commented Dec 28, 2022 •

edited

Loading

mohammed90 left a comment

emilylange commented Dec 28, 2022

emilylange left a comment

mohammed90 commented Dec 28, 2022

Footnotes

francislavoie commented Dec 28, 2022

emilylange left a comment

mholt commented Dec 28, 2022

ci: Fix goreleaser deprecation #5270

ci: Fix goreleaser deprecation #5270

Conversation

francislavoie commented Dec 28, 2022 • edited Loading

mohammed90 left a comment

Choose a reason for hiding this comment

emilylange commented Dec 28, 2022

emilylange left a comment

Choose a reason for hiding this comment

Footnotes

mohammed90 commented Dec 28, 2022

Footnotes

francislavoie commented Dec 28, 2022

emilylange left a comment

Choose a reason for hiding this comment

mholt commented Dec 28, 2022

francislavoie commented Dec 28, 2022 •

edited

Loading