-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support default values in placeholders #5275
Open
JensErat
wants to merge
10
commits into
caddyserver:master
Choose a base branch
from
mercedes-benz:variable-defaults
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Feb 7, 2023
-
Support default values in placeholders
Support variable expansion also in placeholders, like in `{unsetPlaceholder:default value}`. Implemented similarly to caddyserver#3682, which provided defaults for environment variable expansion. Closes caddyserver#1793. Signed-off-by: Jens Erat <jens.erat@mercedes-benz.com>
Configuration menu - View commit details
-
Copy full SHA for c4b6f23 - Browse repository at this point
Copy the full SHA c4b6f23View commit details -
remove optimization that breaks unescaping closing braces
If we have a string `\}`, we'd expect this to be interpreted as `}`, similar to how `\}\{` would be interpreted as `}{`. If we optimize early by searching for opening braces, we'd not strip the escape character here. Signed-off-by: Jens Erat <jens.erat@mercedes-benz.com>
Configuration menu - View commit details
-
Copy full SHA for ee5fdb5 - Browse repository at this point
Copy the full SHA ee5fdb5View commit details -
The old parser logic was quite complicated and does not support nested placeholder evaluation for defaults, as does not support counting closing braces. I assume the given approach using two loops and switch statements is more readable, and changes braces matching behavior to support nested defaulting provided in another commit. Signed-off-by: Jens Erat <jens.erat@mercedes-benz.com>
Configuration menu - View commit details
-
Copy full SHA for f2a925a - Browse repository at this point
Copy the full SHA f2a925aView commit details -
support nested placeholder defaults
Signed-off-by: Jens Erat <jens.erat@mercedes-benz.com>
Configuration menu - View commit details
-
Copy full SHA for e3d0e54 - Browse repository at this point
Copy the full SHA e3d0e54View commit details -
Configuration menu - View commit details
-
Copy full SHA for dc5c1ac - Browse repository at this point
Copy the full SHA dc5c1acView commit details -
Configuration menu - View commit details
-
Copy full SHA for f3c560d - Browse repository at this point
Copy the full SHA f3c560dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f91215 - Browse repository at this point
Copy the full SHA 5f91215View commit details -
Configuration menu - View commit details
-
Copy full SHA for 83f0005 - Browse repository at this point
Copy the full SHA 83f0005View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d8fba4 - Browse repository at this point
Copy the full SHA 2d8fba4View commit details
Commits on Feb 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 66aae70 - Browse repository at this point
Copy the full SHA 66aae70View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.