Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fileserver: Add color-scheme meta tag #5475

Merged
merged 1 commit into from
Apr 3, 2023
Merged

fileserver: Add color-scheme meta tag #5475

merged 1 commit into from
Apr 3, 2023

Conversation

kidonng
Copy link
Contributor

@kidonng kidonng commented Apr 2, 2023

Use <meta name="color-scheme"> to mark the page compatible with both light and dark themes, and let browser adapt to the themes as well.

Before:

image

After:

image

@mholt
Copy link
Member

mholt commented Apr 2, 2023

Thanks, I hadn't heard of this before.

PS. Are those screenshots from the latest on master? We have a new browse template. I'm sure it'll work fine for that too but might be worth checking :D

@kidonng
Copy link
Contributor Author

kidonng commented Apr 2, 2023

Oops, should have clarified, the screenshots are taken with the latest release.

The meta tag just tells the brower to blend in, so it would likely to look fine if custom styles are well-made. But I agree it's worth checking.

@francislavoie francislavoie added the bug 🐞 Something isn't working label Apr 3, 2023
@francislavoie francislavoie added this to the v2.7.0 milestone Apr 3, 2023
@francislavoie francislavoie merged commit f9bd2d3 into caddyserver:master Apr 3, 2023
@mholt
Copy link
Member

mholt commented Apr 3, 2023

Gotcha, yeah that should be fine then :) Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants