caddyfile: Stricter parsing, error for brace on new line #5505
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feedback from https://caddy.community/t/caddy-as-an-authentication-proxy-to-secure-endpoint/19691 made me realize we should be a bit stricter with parsing braces.
This makes this config cause an error:
The other changes to
reverse_proxy
/php_fastcgi
/forward_auth
were to fix the errorexpecting 'https://' but got '://'
from that thread; essentially, the upstreams were being parsed for each iteration of the unmarshal loop withRemainingArgs()
but that doesn't make sense. Changing the loop means both the shortcut directives would misbehave due to the dispenser cursor being in the wrong place, so they need to be advanced before calling down.