-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix file browser footer while in grid mode #5536
Conversation
Signed-off-by: Odyssey <odyssey346@disroot.org>
Signed-off-by: Pistasj <odyssey346@disroot.org>
I think it looks better before, honestly. I don't think the footer should grow. It also stretches the gradient which causes worse color banding. What we could do is change the black background below the footer to a different color to better fit. But I don't think the footer should be resized. |
It already has that gradient in list view, but I agree. Maybe you could change the background in grid view? |
Should the footer be stuck to the bottom (but not span the remaining height) instead? |
I suggest removing this
This makes the gradient bg go all the the way to the bottom of the viewport. Makes the color banding pretty rough in some cases though, stretching the gradient that far. But 🤷♂️ |
Sorry, just took a lunch break, and am about to run some errands -- I'll look at this again in a little bit :) Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK finally had a chance to clone this down and check it out. It definitely looks better, thanks!
I noticed, however, that it pushes the logo all the way to the bottom of the screen. I know I suggested this earlier, but on second thought I don't think it needs to be down there.
Turns out that this is fixed with just the 1 line of CSS.
IMO it looks good on my monitor (no banding that I can see). And I prefer to keep things simple.
If the suggestion is accepted we can just merge this in I think 👍
Signed-off-by: Odyssey <odyssey346@disroot.org>
Awesome, thank you for the contribution!! If we decide for some reason that the footer is best at the bottom, we know what to do now. :) Thanks again. |
:D |
@pistasjis Also, you may notice I just pushed bd34cb6 which adds a lot more filetypes for the icons. |
They look nice. I've used Tabler before and they're one of my favourite iconsets |
I looked at the new file browser template and found it to be pretty good looking. Nice job! I tried it locally and found that the footer looked something like this:
The black space after the footer looks kinda awkward, so I decided to fix it. With this PR, it looks like this: