Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

caddyhttp: support custom network for HTTP/3 #5573

Merged
merged 1 commit into from
Jun 14, 2023
Merged

caddyhttp: support custom network for HTTP/3 #5573

merged 1 commit into from
Jun 14, 2023

Conversation

oncilla
Copy link
Contributor

@oncilla oncilla commented Jun 13, 2023

Allow registering a custom network mapping for HTTP/3. This is useful if the original network for HTTP/1.1 and HTTP/2 is not a standard unix, tcp4, or tcp6 network. To keep backwards compatibility, we fall back to udp if the original network is not registered in the mapping.

Fixes #5555

@oncilla
caddyhttp: support custom network for HTTP/3
ccd7902 
Allow registering a custom network mapping for HTTP/3. This is useful
if the original network for HTTP/1.1 and HTTP/2 is not a standard `unix`,
`tcp4`, or `tcp6` network. To keep backwards compatibility, we fall back
to `udp` if the original network is not registered in the mapping.

Fixes caddyserver#5555
@CLAassistant
Copy link

CLAassistant commented Jun 13, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@oncilla oncilla mentioned this pull request Jun 13, 2023
Closed
mholt
mholt approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

Did you verify that there isn't a race condition? I imagine it should be fine as long as all the changes to the map happen before any goroutines are started.

@mholt mholt added this to the v2.7.0 milestone Jun 13, 2023
@francislavoie
Copy link
Member

francislavoie commented Jun 13, 2023 •
edited
Loading

@mholt we're not doing any race condition checks for RegisterNetwork and RegisterMdule either which uses the same pattern of needing to be called in init(). The godoc comment says as much, so if someone does any differently they're going to have a bad time.

@francislavoie francislavoie added the feature ⚙️ New feature or request label Jun 13, 2023
@mholt
Copy link
Member

mholt commented Jun 13, 2023

I suppose it should be good then. Thanks!

@mholt mholt merged commit 6a41b62 into caddyserver:master Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mholt mholt mholt approved these changes

Assignees
No one assigned
Labels
feature ⚙️ New feature or request
Projects
None yet
Milestone
v2.7.0
Development

Successfully merging this pull request may close these issues.

caddyhttp: allow custom network for HTTP/3
4 participants
@oncilla @CLAassistant @francislavoie @mholt