Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

caddyfile: Reject global request matchers earlier #6339

Merged
merged 1 commit into from
May 24, 2024
Merged

caddyfile: Reject global request matchers earlier #6339

merged 1 commit into from
May 24, 2024

Conversation

francislavoie
Copy link
Member

Fixes #6332

@francislavoie francislavoie added the bug 🐞 Something isn't working label May 23, 2024
@francislavoie francislavoie added this to the v2.8.0 milestone May 23, 2024
@francislavoie francislavoie requested a review from mholt May 23, 2024 21:43
@francislavoie francislavoie mentioned this pull request May 23, 2024
Closed
mholt
mholt approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, thanks so much!

@mholt mholt merged commit f6d2c29 into master May 24, 2024
23 checks passed
@mholt mholt deleted the reject-global-matcher-earlier branch May 24, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mholt mholt mholt approved these changes

Assignees
No one assigned
Labels
bug 🐞 Something isn't working
Projects
None yet
Milestone
v2.8.0
Development

Successfully merging this pull request may close these issues.

Improve error message when trying to define a global matcher
2 participants
@francislavoie @mholt