docs: Add /reverse_proxy/upstreams API docs
#157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mholt
reviewed
Apr 28, 2021
There was a problem hiding this comment.
LGTM, just a nit on some awkward phrasing.
It might be worth making a more concise distinction between "healthy" and "available" -- the last paragraph kind of tries to explain this, but instead does so from the angle of active and passive health checks. As we discussed, whether a host is "available" is a property of the actual RP handler, not the host itself, and that's what the paragraph rightly explains, but I think it could be clearer. I will try to write up a suggestion if I have time...
Thanks for completing this!
Co-authored-by: Matt Holt <mholt@users.noreply.github.com>
|
Sure 👍 I'll let you re-review this when you can. You often find better wording, but at least this gives you the basis for this content 😄 |
Co-authored-by: Matt Holt <mholt@users.noreply.github.com>
|
Sounds good to me 👍 😁 |
mholt
approved these changes
May 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See caddyserver/caddy#4125