Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readme: ensure the example is valid Go #1

Merged
merged 1 commit into from
Mar 21, 2020
Merged

readme: ensure the example is valid Go #1

merged 1 commit into from
Mar 21, 2020

Conversation

mohammed90
Copy link
Member

I know we can omit the builder.CaddyPlugin but I added it for readability

mholt
mholt approved these changes Mar 21, 2020
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😃

@mholt mholt merged commit 203ce92 into caddyserver:master Mar 21, 2020
@mohammed90 mohammed90 deleted the fix-example branch March 21, 2020 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mholt mholt mholt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mohammed90 @mholt