fix: xcaddy run on windows with go 1.19 #117
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @mholt,
you were right #116 is a windows specific problem. I found this more detailed issue golang/go#43724 were the reasons for the change are described.
Because there is a special case in getCaddyOutputFile for windows xcaddy does exactly that, but it really wants to use the binary from the current directory.
For me
run
andbuild
also works without the windows special case, but #33 explicitly added the.exe
ending so I kept it.Closes #116