Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Update Go versions #172

Merged
merged 1 commit into from
Feb 16, 2024
Merged

ci: Update Go versions #172

merged 1 commit into from
Feb 16, 2024

Conversation

francislavoie
Copy link
Member

No description provided.

@francislavoie
Copy link
Member Author

Hmm... why didn't CI run??

mohammed90
mohammed90 approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@mohammed90 mohammed90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, Francis!

.github/workflows/ci.yml Show resolved Hide resolved
@francislavoie francislavoie reopened this Feb 15, 2024
@francislavoie
Copy link
Member Author

I'm confused. It's not producing actions.

mohammed90
mohammed90 reviewed Feb 15, 2024
View reviewed changes
Copy link
Member

@mohammed90 mohammed90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably need to change the on.{push,pull_request}.branches (lines 5-11) to * 🤔

@francislavoie
Copy link
Member Author

but the PR is to master... it's always worked 😬

@mohammed90
Copy link
Member

but the PR is to master... it's always worked 😬

True. I'm as confused as you are.

@francislavoie
Copy link
Member Author

Bleh. I guess we could just merge. It should run on master. If an error happens I'll just do another PR to fix it.

@francislavoie francislavoie merged commit 51aadd6 into master Feb 16, 2024
@francislavoie francislavoie deleted the ci-updates branch February 16, 2024 00:00
@francislavoie
Copy link
Member Author

🤷‍♂️ it ran and passed. Whatever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohammed90 mohammed90 mohammed90 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francislavoie @mohammed90