Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: always inject the nobadger build tag #173

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Conversation

mohammed90
Copy link
Member

Its simplicity making me worried I missed something

@francislavoie
Copy link
Member

francislavoie commented Feb 16, 2024

What if a user wants to opt out of this and actually include badger?

What if they specified this flag themselves, will it break from having it twice?

Maybe we add an XCADDY_BADGER=1 or something?

@mohammed90
Copy link
Member Author

What if a user wants to opt out of this and actually include badger?

This build-tag only affects the github.com/smallstep/nosql library. It'll only be an issue if a user wants to use the github.com/smallstep/nosql with badger, which I have no interest in supporting. Badger is nothing but trouble.

What if they specified this flag themselves, will it break from having it twice?

It'll work without issues. The compiler does not complain.

Maybe we add an XCADDY_BADGER=1 or something?

I don't like exposing the internal implementation this way. It feels like breaking the abstraction. It isn't something they should be aware of.

@mohammed90 mohammed90 merged commit d6f5a3e into master Feb 19, 2024
8 checks passed
@mohammed90 mohammed90 deleted the inject-nobadger branch February 19, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants