Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add XCADDY_NO_BUILD to not run go build #41

Merged
merged 3 commits into from
Feb 5, 2021

Conversation

dunglas
Copy link
Contributor

@dunglas dunglas commented Nov 25, 2020

Mercure and Vulcain now use Caddy. They are available as Caddy modules but also as standalone binaries build with GoReleaser.
I managed to use xcaddy to prepare the source code and goreleaser to cross-compile and package the binary: dunglas/mercure#398.

Currently, xcaddy always compiles the project. This proposed XCADDY_NO_BUILD environment variable allows to prepare the source code but not run go build to save some CI time (go build is run by GoReleaser).

Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I guess this won't hurt to have. Just a nit on the naming.

README.md Outdated Show resolved Hide resolved
builder.go Outdated Show resolved Hide resolved
@francislavoie
Copy link
Member

I think you need a rebase, your changes seem to have removed some of the changes on master.

Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks very much!

@mholt mholt merged commit 5734acd into caddyserver:master Feb 5, 2021
@dunglas dunglas deleted the feat/no-build branch February 5, 2021 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants