-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
accept replacements with branches of github forks #51
Conversation
Have you tested that this works?
Actual usecase from someone else who ran into this right after I reported it 😅 I'll try it out myself later when I get to my env, but impl looks about right to me. |
Works:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this patch! Double-check my logic on my one nit; otherwise this LGTM.
If the replacement path starts with a `.`, then the path is definitely not absolute.
Closes #50